Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(resolve): cover the codes that parse the fs path contained postfix #12436

Merged
merged 2 commits into from
Mar 16, 2023
Merged

test(resolve): cover the codes that parse the fs path contained postfix #12436

merged 2 commits into from
Mar 16, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Mar 16, 2023

Description

Add a test case for

vite/packages/vite/src/node/plugins/resolve.ts

Lines 479 to 493 in d23605d

// if there is a postfix, try resolving it as a complete path first (#4703)
if (
postfix &&
(res = tryResolveFile(
fsPath,
'',
options,
false,
targetWeb,
options.tryPrefix,
options.skipPackageJson,
))
) {
return res
}

Additional context

Even without these codes, the new test case still passes. It's duplicate with lines below in the new test case.

vite/packages/vite/src/node/plugins/resolve.ts

Lines 545 to 558 in d23605d

if (
postfix &&
(res = tryResolveFile(
fsPath,
'',
options,
tryIndex,
targetWeb,
options.tryPrefix,
options.skipPackageJson,
))
) {
return res
}

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

Just in case, @sun0day, there is an issue in npm that may be affecting CI

@patak-dev
Copy link
Member

Actually, @dominikg pointed out the issue is that the lockfile needs to be synced after adding the new private dep. @sun0day you should do an install again and commit that 👍🏼

@sun0day
Copy link
Member Author

sun0day commented Mar 16, 2023

Committed. Sorry, I forgot.

@patak-dev patak-dev merged commit 4b587b0 into vitejs:main Mar 16, 2023
@patak-dev patak-dev mentioned this pull request Mar 17, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sun0day @patak-dev @bluwy